Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breakout CqlTranslatorOptionsMapper into its own project. #1473

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

JPercival
Copy link
Contributor

  • Add a new cql-to-elm-jackson module
  • Moved the CqlTranslatorOptionsMapper and tests to that project
  • I anticipate some of these modules will be recombined once we have Kotlin serialization sorted.

Copy link

Formatting check succeeded!

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
69.3% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Copy link

codecov bot commented Dec 16, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 65.91%. Comparing base (44f4bdf) to head (3901bb9).
Report is 1 commits behind head on feature-kotlin.

Files with missing lines Patch % Lines
...qframework/cql/cq2elm/CqlTranslatorOptionsMixin.kt 0.00% 1 Missing ⚠️
...rg/cqframework/cql/cql2elm/CqlTranslatorOptions.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                 Coverage Diff                  @@
##             feature-kotlin    #1473      +/-   ##
====================================================
- Coverage             65.97%   65.91%   -0.06%     
+ Complexity             4881     4872       -9     
====================================================
  Files                   490      491       +1     
  Lines                 28797    28800       +3     
  Branches               5421     5421              
====================================================
- Hits                  18999    18984      -15     
- Misses                 7587     7605      +18     
  Partials               2211     2211              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JPercival JPercival merged commit 26c56e0 into feature-kotlin Dec 16, 2024
6 of 7 checks passed
@JPercival JPercival deleted the feature-breakout-cql-options-mapper branch December 16, 2024 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant